From 1b866757fc4cb135674f46c96909e900fcea91a2 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Wed, 21 Aug 2013 16:17:47 -0700 Subject: sysfs: fix placement of EXPORT_SYMBOL() The export should happen after the function, not at the bottom of the file, so fix that up. Signed-off-by: Greg Kroah-Hartman --- fs/sysfs/bin.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'fs/sysfs/bin.c') diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c index 15c68f9489ae..745f57f7d089 100644 --- a/fs/sysfs/bin.c +++ b/fs/sysfs/bin.c @@ -481,7 +481,6 @@ void unmap_bin_file(struct sysfs_dirent *attr_sd) * @kobj: object. * @attr: attribute descriptor. */ - int sysfs_create_bin_file(struct kobject *kobj, const struct bin_attribute *attr) { @@ -489,19 +488,16 @@ int sysfs_create_bin_file(struct kobject *kobj, return sysfs_add_file(kobj->sd, &attr->attr, SYSFS_KOBJ_BIN_ATTR); } - +EXPORT_SYMBOL_GPL(sysfs_create_bin_file); /** * sysfs_remove_bin_file - remove binary file for object. * @kobj: object. * @attr: attribute descriptor. */ - void sysfs_remove_bin_file(struct kobject *kobj, const struct bin_attribute *attr) { sysfs_hash_and_remove(kobj->sd, NULL, attr->attr.name); } - -EXPORT_SYMBOL_GPL(sysfs_create_bin_file); EXPORT_SYMBOL_GPL(sysfs_remove_bin_file); -- cgit v1.2.3 From 1b18dc2beb31f588db1c75901b0112324c72124f Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Wed, 21 Aug 2013 16:28:26 -0700 Subject: sysfs: fix up space coding style issues This fixes up all of the space-related coding style issues for the sysfs code. Signed-off-by: Greg Kroah-Hartman --- fs/sysfs/bin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'fs/sysfs/bin.c') diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c index 745f57f7d089..26861e5a9fc4 100644 --- a/fs/sysfs/bin.c +++ b/fs/sysfs/bin.c @@ -391,7 +391,7 @@ out_unlock: return rc; } -static int open(struct inode * inode, struct file * file) +static int open(struct inode *inode, struct file *file) { struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; struct bin_attribute *attr = attr_sd->s_bin_attr.bin_attr; @@ -435,7 +435,7 @@ static int open(struct inode * inode, struct file * file) return error; } -static int release(struct inode * inode, struct file * file) +static int release(struct inode *inode, struct file *file) { struct bin_buffer *bb = file->private_data; -- cgit v1.2.3 From 060cc749e9c50dfc8d1a8696aa0da520aa714977 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Wed, 21 Aug 2013 16:34:59 -0700 Subject: sysfs: fix up uaccess.h coding style warnings This fixes the uaccess.h warnings in the sysfs.c files. Signed-off-by: Greg Kroah-Hartman --- fs/sysfs/bin.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'fs/sysfs/bin.c') diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c index 26861e5a9fc4..c590cabd57bb 100644 --- a/fs/sysfs/bin.c +++ b/fs/sysfs/bin.c @@ -22,8 +22,7 @@ #include #include #include - -#include +#include #include "sysfs.h" -- cgit v1.2.3