summaryrefslogtreecommitdiff
path: root/net/ethernet
diff options
context:
space:
mode:
authorDmitry Popov <dp@highloadlab.com>2013-04-11 08:55:07 +0000
committerBen Hutchings <ben@decadent.org.uk>2013-05-13 15:02:37 +0100
commit0df4e84995c7f69103a3553d1a3dcb5da4caab79 (patch)
treed81742aa83c6e3f26b77940d9510bdd95c4be16d /net/ethernet
parent666617d8dda49d71ff96fcf961852941c47fc13a (diff)
tcp: incoming connections might use wrong route under synflood
[ Upstream commit d66954a066158781ccf9c13c91d0316970fe57b6 ] There is a bug in cookie_v4_check (net/ipv4/syncookies.c): flowi4_init_output(&fl4, 0, sk->sk_mark, RT_CONN_FLAGS(sk), RT_SCOPE_UNIVERSE, IPPROTO_TCP, inet_sk_flowi_flags(sk), (opt && opt->srr) ? opt->faddr : ireq->rmt_addr, ireq->loc_addr, th->source, th->dest); Here we do not respect sk->sk_bound_dev_if, therefore wrong dst_entry may be taken. This dst_entry is used by new socket (get_cookie_sock -> tcp_v4_syn_recv_sock), so its packets may take the wrong path. Signed-off-by: Dmitry Popov <dp@highloadlab.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'net/ethernet')
0 files changed, 0 insertions, 0 deletions