diff options
author | Stanislaw Gruszka <sgruszka@redhat.com> | 2011-03-31 17:36:26 +0200 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2011-04-07 15:34:11 -0400 |
commit | 3598e1774c94e55c71b585340e7dc4538f310e3f (patch) | |
tree | 09f7d500b76090f3cdb66bf2162d63d222696898 /drivers/hid | |
parent | 08b8099c128d601fd675b212ef8b10397706b633 (diff) |
iwlwifi: fix enqueue hcmd race conditions
We mark command as huge by using meta->flags from other (non huge) command,
but flags can be possibly overridden, when non huge command is enqueued,
what can lead to:
WARNING: at lib/dma-debug.c:696 dma_debug_device_change+0x1a3/0x1f0()
DMA-API: device driver has pending DMA allocations while released from device [count=1]
To fix introduce additional CMD_MAPPED to mark command as mapped and
serialize iwl_enqueue_hcmd() with iwl_tx_cmd_complete() using
hcmd_lock. Serialization will also fix possible race conditions,
because q->read_ptr, q->write_ptr are modified/used in parallel.
On the way fix whitespace.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/hid')
0 files changed, 0 insertions, 0 deletions