diff options
| author | Corey Minyard <cminyard@mvista.com> | 2018-06-21 15:32:48 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-11-20 18:00:09 +0100 |
| commit | 8d65f82de9f4cb88c7ee8a7fe1c9112283b5e66d (patch) | |
| tree | 437a7ee1bb8d0b6343a3cff1c161774bc66130e9 | |
| parent | 338856a48f39eba8518893fb0b3ea3f69bb19315 (diff) | |
ipmi:dmi: Ignore IPMI SMBIOS entries with a zero base address
[ Upstream commit 1574608f5f4204440d6d9f52b971aba967664764 ]
Looking at logs from systems all over the place, it looks like tons
of broken systems exist that set the base address to zero. I can
only guess that is some sort of non-standard idea to mark the
interface as not being present. It can't be zero, anyway, so just
complain and ignore it.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/char/ipmi/ipmi_dmi.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/char/ipmi/ipmi_dmi.c b/drivers/char/ipmi/ipmi_dmi.c index c3a23ec3e76f..a37d9794170c 100644 --- a/drivers/char/ipmi/ipmi_dmi.c +++ b/drivers/char/ipmi/ipmi_dmi.c @@ -197,6 +197,10 @@ static void __init dmi_decode_ipmi(const struct dmi_header *dm) slave_addr = data[DMI_IPMI_SLAVEADDR]; memcpy(&base_addr, data + DMI_IPMI_ADDR, sizeof(unsigned long)); + if (!base_addr) { + pr_err("Base address is zero, assuming no IPMI interface\n"); + return; + } if (len >= DMI_IPMI_VER2_LENGTH) { if (type == IPMI_DMI_TYPE_SSIF) { offset = 0; |