diff options
| author | Luo Ji <ji.luo@nxp.com> | 2019-03-14 11:13:28 +0800 |
|---|---|---|
| committer | Ji Luo <ji.luo@nxp.com> | 2019-03-15 12:25:18 +0800 |
| commit | ae4200a47bdb28611ca7270333d209bd0c52e3dd (patch) | |
| tree | 8e5ee3010144b312d109373415c8a662d04b597f /drivers | |
| parent | fa6a390058bc570bb28501051810ffce74dab0fd (diff) | |
MA-14370 [coverity] Buffer not null terminated
Fix coverity issue:
CID 43787: Buffer not null terminated (BUFFER_SIZE_WARNING)
buffer_size_warning: Calling strncpy with a maximum size argument
of 32 bytes on destination array sdev.name of size 32 bytes might
leave the destination string unterminated.
Test: Coverity scan pass.
Change-Id: Ib10e631bab893cb9cd1484082229f806b02849ba
Signed-off-by: Luo Ji <ji.luo@nxp.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/serial/serial-uclass.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c index eb8f80a459..482b811952 100644 --- a/drivers/serial/serial-uclass.c +++ b/drivers/serial/serial-uclass.c @@ -425,7 +425,7 @@ static int serial_post_probe(struct udevice *dev) return 0; memset(&sdev, '\0', sizeof(sdev)); - strncpy(sdev.name, dev->name, sizeof(sdev.name)); + strncpy(sdev.name, dev->name, sizeof(sdev.name) - 1); sdev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT | DEV_FLAGS_DM; sdev.priv = dev; sdev.putc = serial_stub_putc; |