From e05c4f3f2fea7b75bb6998ca8f80a8b96ad681dc Mon Sep 17 00:00:00 2001 From: Rolf Eike Beer Date: Tue, 20 Nov 2018 12:51:04 +0100 Subject: gk20a: do not BUG if the ioctl size does not match Signed-off-by: Rolf Eike Beer Acked-by: Marcel Ziswiler --- drivers/gpu/nvgpu/gk20a/ctrl_gk20a.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nvgpu/gk20a/ctrl_gk20a.c b/drivers/gpu/nvgpu/gk20a/ctrl_gk20a.c index 9128959f60a7..3a8c3ff4c645 100644 --- a/drivers/gpu/nvgpu/gk20a/ctrl_gk20a.c +++ b/drivers/gpu/nvgpu/gk20a/ctrl_gk20a.c @@ -96,11 +96,10 @@ long gk20a_ctrl_dev_ioctl(struct file *filp, unsigned int cmd, unsigned long arg if ((_IOC_TYPE(cmd) != NVHOST_GPU_IOCTL_MAGIC) || (_IOC_NR(cmd) == 0) || - (_IOC_NR(cmd) > NVHOST_GPU_IOCTL_LAST)) + (_IOC_NR(cmd) > NVHOST_GPU_IOCTL_LAST) || + (_IOC_SIZE(cmd) > NVHOST_GPU_IOCTL_MAX_ARG_SIZE)) return -EFAULT; - BUG_ON(_IOC_SIZE(cmd) > NVHOST_GPU_IOCTL_MAX_ARG_SIZE); - if (_IOC_DIR(cmd) & _IOC_WRITE) { if (copy_from_user(buf, (void __user *)arg, _IOC_SIZE(cmd))) return -EFAULT; -- cgit v1.2.3