diff options
| author | Fabio Estevam <fabio.estevam@freescale.com> | 2014-11-14 02:14:47 -0200 |
|---|---|---|
| committer | Oleksandr Suvorov <oleksandr.suvorov@toradex.com> | 2019-04-26 11:01:30 +0300 |
| commit | 047e8dd968015d6fbcae4fded5313c741952ef68 (patch) | |
| tree | 1dd4ad88c0054899fdcd11b01006e27b4ea00a58 /sound/soc/codecs/sgtl5000.c | |
| parent | 79c4b2cd2d7301027c400d0e7d844e0e8c81f899 (diff) | |
ASoC: sgtl5000: Fix SMALL_POP bit definition
commit c251ea7bd7a04f1f2575467e0de76e803cf59149 upstream
On a mx28evk with a sgtl5000 codec we notice a loud 'click' sound to happen
5 seconds after the end of a playback.
The SMALL_POP bit should fix this, but its definition is incorrect:
according to the sgtl5000 manual it is bit 0 of CHIP_REF_CTRL register, not
bit 1.
Fix the definition accordingly and enable the bit as intended per the code
comment.
After applying this change, no loud 'click' sound is heard after playback
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Diffstat (limited to 'sound/soc/codecs/sgtl5000.c')
| -rw-r--r-- | sound/soc/codecs/sgtl5000.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 13b201771d5f..07fe76c8cc8d 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -1323,8 +1323,7 @@ static int sgtl5000_probe(struct snd_soc_codec *codec) /* enable small pop, introduce 400ms delay in turning off */ snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, - SGTL5000_SMALL_POP, - SGTL5000_SMALL_POP); + SGTL5000_SMALL_POP, 1); /* disable short cut detector */ snd_soc_write(codec, SGTL5000_CHIP_SHORT_CTRL, 0); |