diff options
| author | Laxman Dewangan <ldewangan@nvidia.com> | 2014-02-21 15:11:33 +0530 |
|---|---|---|
| committer | Laxman Dewangan <ldewangan@nvidia.com> | 2014-02-25 06:26:02 -0800 |
| commit | 3b0f37859784d84519f6f7523a9b29aa0e676d16 (patch) | |
| tree | 6dfbfe72cf4b71d88f2043a6d9eade1e13050605 /drivers/dma | |
| parent | dd7d4a1a00322fbd47b9d7e4d1193e529ead2aac (diff) | |
dma: tegra: do not abort dma if next configuration skipped.
There is a case in continuous mode where the dma transfer completes
and interrupt is pending before the next transfer programmed. In this
case, next dma configuration skipped till interrupt served. So in this
case, do not abort the dma from transfers, confgure the next transfer
once pending interrupt handled.
bug 1464356
Change-Id: Ia4966e062afac613232b5bf5f4d1c9452037d985
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Reviewed-on: http://git-master/r/374167
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/tegra20-apb-dma.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index 11b0d3602eac..91888b078bce 100644 --- a/drivers/dma/tegra20-apb-dma.c +++ b/drivers/dma/tegra20-apb-dma.c @@ -159,6 +159,7 @@ struct tegra_dma_sg_req { struct tegra_dma_channel_regs ch_regs; int req_len; bool configured; + bool skipped; bool last_sg; bool half_done; struct list_head node; @@ -470,6 +471,7 @@ static void tegra_dma_configure_for_next(struct tegra_dma_channel *tdc, if (status & TEGRA_APBDMA_STATUS_ISE_EOC) { dev_err(tdc2dev(tdc), "Skipping new configuration as interrupt is pending\n"); + nsg_req->skipped = true; tegra_dma_resume(tdc); return; } @@ -483,6 +485,7 @@ static void tegra_dma_configure_for_next(struct tegra_dma_channel *tdc, tdc_write(tdc, TEGRA_APBDMA_CHAN_CSR, nsg_req->ch_regs.csr | TEGRA_APBDMA_CSR_ENB); nsg_req->configured = true; + nsg_req->skipped = false; tegra_dma_resume(tdc); } @@ -498,6 +501,7 @@ static void tdc_start_head_req(struct tegra_dma_channel *tdc) typeof(*sg_req), node); tegra_dma_start(tdc, sg_req); sg_req->configured = true; + sg_req->skipped = false; tdc->busy = true; } @@ -564,7 +568,7 @@ static bool handle_continuous_head_request(struct tegra_dma_channel *tdc, * looping of transfer can not continue. */ hsgreq = list_first_entry(&tdc->pending_sg_req, typeof(*hsgreq), node); - if (!hsgreq->configured) { + if (!hsgreq->configured && !hsgreq->skipped) { tegra_dma_stop(tdc); dev_err(tdc2dev(tdc), "Error in dma transfer, aborting dma\n"); tegra_dma_abort_all(tdc); @@ -632,6 +636,7 @@ static void handle_cont_sngl_cycle_dma_done(struct tegra_dma_channel *tdc, if (!list_is_last(&sgreq->node, &tdc->pending_sg_req)) { list_move_tail(&sgreq->node, &tdc->pending_sg_req); sgreq->configured = false; + sgreq->skipped = false; st = handle_continuous_head_request(tdc, sgreq, to_terminate); if (!st) dma_desc->dma_status = DMA_ERROR; @@ -1041,6 +1046,7 @@ static struct dma_async_tx_descriptor *tegra_dma_prep_slave_sg( sg_req->ch_regs.apb_seq = apb_seq; sg_req->ch_regs.ahb_seq = ahb_seq; sg_req->configured = false; + sg_req->skipped = false; sg_req->last_sg = false; sg_req->dma_desc = dma_desc; sg_req->req_len = len; @@ -1175,6 +1181,7 @@ struct dma_async_tx_descriptor *tegra_dma_prep_dma_cyclic( sg_req->ch_regs.apb_seq = apb_seq; sg_req->ch_regs.ahb_seq = ahb_seq; sg_req->configured = false; + sg_req->skipped = false; sg_req->half_done = false; sg_req->last_sg = false; sg_req->dma_desc = dma_desc; |