diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2015-07-04 13:23:42 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-08-10 12:21:58 -0700 |
| commit | 1c57a6c95d3de1ea32010d88b9b93984d3302e8d (patch) | |
| tree | 32d00d51771172ce3fa008ecbe9bc9eca0a129a4 | |
| parent | fd1a8f57bfd8686709c17cbe878470bd43fb3c4e (diff) | |
hwmon: (nct7802) Fix integer overflow seen when writing voltage limits
commit 9200bc4c28cd8992eb5379345abd6b4f0c93df16 upstream.
Writing a large value into a voltage limit attribute can result
in an overflow due to an auto-conversion from unsigned long to
unsigned int.
Cc: Constantine Shulyupin <const@MakeLinux.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/hwmon/nct7802.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c index 28fcb2e246d5..fbfc02bb2cfa 100644 --- a/drivers/hwmon/nct7802.c +++ b/drivers/hwmon/nct7802.c @@ -195,7 +195,7 @@ abort: } static int nct7802_write_voltage(struct nct7802_data *data, int nr, int index, - unsigned int voltage) + unsigned long voltage) { int shift = 8 - REG_VOLTAGE_LIMIT_MSB_SHIFT[index - 1][nr]; int err; |