diff options
| author | NeilBrown <neilb@suse.de> | 2012-11-22 15:12:09 +1100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-12-03 11:47:07 -0800 |
| commit | ecf049ce86e1d93bc9a3376facf31d7244338089 (patch) | |
| tree | 1143b5ca06537fb8e35a8e2584d7059247df904d | |
| parent | 8c98fbaa55508732bb5a9f46b3c6cf60daa8e526 (diff) | |
md/raid10: decrement correct pending counter when writing to replacement.
commit 884162df2aadd7414bef4935e1a54976fd4e3988 upstream.
When a write to a replacement device completes, we carefully
and correctly found the rdev that the write actually went to
and the blithely called rdev_dec_pending on the primary rdev,
even if this write was to the replacement.
This means that any writes to an array while a replacement
was ongoing would cause the nr_pending count for the primary
device to go negative, so it could never be removed.
This bug has been present since replacement was introduced in
3.3, so it is suitable for any -stable kernel since then.
Reported-by: "George Spelvin" <linux@horizon.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/md/raid10.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 4a038cdc0b54..a2b5304b4eb8 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -476,7 +476,7 @@ static void raid10_end_write_request(struct bio *bio, int error) */ one_write_done(r10_bio); if (dec_rdev) - rdev_dec_pending(conf->mirrors[dev].rdev, conf->mddev); + rdev_dec_pending(rdev, conf->mddev); } /* |