diff options
author | Johan Hovold <johan@kernel.org> | 2015-01-26 12:02:45 +0100 |
---|---|---|
committer | Ben Hutchings <ben@decadent.org.uk> | 2015-03-06 00:39:18 +0000 |
commit | 67cb64715f1edfa5e05812bf70913c18d065421c (patch) | |
tree | bd618f43e4321803e9f940c28a81243e7eab9dfa | |
parent | 7829c20e43e9f915231e8b7c97aaa1acc9133126 (diff) |
gpio: sysfs: fix memory leak in gpiod_export_link
commit 0f303db08df0df9bd0966443ad6001e63960af16 upstream.
Fix memory leak in the gpio sysfs interface due to failure to drop
reference to device returned by class_find_device when creating a link.
Fixes: a4177ee7f1a8 ("gpiolib: allow exported GPIO nodes to be named
using sysfs links")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r-- | drivers/gpio/gpiolib.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 51e5ee8912ca..72ebde423081 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -821,6 +821,7 @@ int gpio_export_link(struct device *dev, const char *name, unsigned gpio) if (tdev != NULL) { status = sysfs_create_link(&dev->kobj, &tdev->kobj, name); + put_device(tdev); } else { status = -ENODEV; } |