diff options
| author | Jan Kara <jack@suse.cz> | 2013-12-03 11:20:06 +0100 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2014-02-15 19:20:12 +0000 |
| commit | f5b4f2e824dec9808d55287576a7b83d80bae937 (patch) | |
| tree | bcfb5d8ba6379b0ed101dd5a1d380554aba73a2b | |
| parent | 4645e4ee32aee01a85bdc03348982a65c65ce216 (diff) | |
ext2: Fix oops in ext2_get_block() called from ext2_quota_write()
commit df4e7ac0bb70abc97fbfd9ef09671fc084b3f9db upstream.
ext2_quota_write() doesn't properly setup bh it passes to
ext2_get_block() and thus we hit assertion BUG_ON(maxblocks == 0) in
ext2_get_blocks() (or we could actually ask for mapping arbitrary number
of blocks depending on whatever value was on stack).
Fix ext2_quota_write() to properly fill in number of blocks to map.
Reviewed-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reported-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | fs/ext2/super.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ext2/super.c b/fs/ext2/super.c index bd8ac164a3bf..94b9e329b712 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c @@ -1448,6 +1448,7 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type, sb->s_blocksize - offset : towrite; tmp_bh.b_state = 0; + tmp_bh.b_size = sb->s_blocksize; err = ext2_get_block(inode, blk, &tmp_bh, 1); if (err < 0) goto out; |