diff options
| author | Jan Kara <jack@suse.cz> | 2012-11-23 14:03:04 +0100 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2012-12-06 11:20:35 +0000 |
| commit | 3b830a12b24fcfd9d241de936b9b11e3b23e9c23 (patch) | |
| tree | 274488d62998864f0db465dd64933bd023a2f6e2 | |
| parent | 32eb44e290d1151e9eb26f57564dae6966190685 (diff) | |
jbd: Fix lock ordering bug in journal_unmap_buffer()
commit 25389bb207987b5774182f763b9fb65ff08761c8 upstream.
Commit 09e05d48 introduced a wait for transaction commit into
journal_unmap_buffer() in the case we are truncating a buffer undergoing commit
in the page stradding i_size on a filesystem with blocksize < pagesize. Sadly
we forgot to drop buffer lock before waiting for transaction commit and thus
deadlock is possible when kjournald wants to lock the buffer.
Fix the problem by dropping the buffer lock before waiting for transaction
commit. Since we are still holding page lock (and that is OK), buffer cannot
disappear under us.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | fs/jbd/transaction.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c index edac00456b2b..7c86b37ebbb4 100644 --- a/fs/jbd/transaction.c +++ b/fs/jbd/transaction.c @@ -1957,7 +1957,9 @@ retry: spin_unlock(&journal->j_list_lock); jbd_unlock_bh_state(bh); spin_unlock(&journal->j_state_lock); + unlock_buffer(bh); log_wait_commit(journal, tid); + lock_buffer(bh); goto retry; } /* |