diff options
| author | Nicolas Iooss <nicolas.iooss_linux@m4x.org> | 2015-04-16 12:44:02 -0700 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2015-06-28 13:39:26 -0400 |
| commit | ba8e7f8c53394b2386e6bd55e487780480f6e0aa (patch) | |
| tree | 48d5c66d8c266fb97336df0d1b82e71f1b050b85 | |
| parent | 50657ec35a942cd5db110c642395b99a5aeb557e (diff) | |
firmware/ihex2fw.c: restore missing default in switch statement
[ Upstream commit d43698e8abb58a6ac47d16e0f47bb55f452e4fc4 ]
Commit 2473238eac95 ("ihex: add support for CS:IP/EIP records") removes
the "default:" statement in the switch block, making the "return
usage();" line dead code and ihex2fw silently ignoring unknown options.
Restore this statement.
This bug was found by building with HOSTCC=clang and adding
-Wunreachable-code-return to HOSTCFLAGS.
Fixes: 2473238eac95 ("ihex: add support for CS:IP/EIP records")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
| -rw-r--r-- | firmware/ihex2fw.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/firmware/ihex2fw.c b/firmware/ihex2fw.c index cf38e159131a..08d90e25abf0 100644 --- a/firmware/ihex2fw.c +++ b/firmware/ihex2fw.c @@ -86,6 +86,7 @@ int main(int argc, char **argv) case 'j': include_jump = 1; break; + default: return usage(); } } |