diff options
| author | Axel Lin <axel.lin@ingics.com> | 2014-07-30 11:13:52 +0800 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-09-03 21:31:22 +0200 |
| commit | 497bba1cc4a309d7fd44defaedfdbc1de8a471a2 (patch) | |
| tree | 6f1505e7c812b13eace6078c5b423f46e6616ce9 | |
| parent | b800e2f89990e68cba2ce8f6fe07b9c39af8f2f1 (diff) | |
hwmon: (ads1015) Fix off-by-one for valid channel index checking
commit 56de1377ad92f72ee4e5cb0faf7a9b6048fdf0bf upstream.
Current code uses channel as array index, so the valid channel value is
0 .. ADS1015_CHANNELS - 1.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/hwmon/ads1015.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c index 7f9dc2f86b63..22e0c926989d 100644 --- a/drivers/hwmon/ads1015.c +++ b/drivers/hwmon/ads1015.c @@ -198,7 +198,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client) } channel = be32_to_cpup(property); - if (channel > ADS1015_CHANNELS) { + if (channel >= ADS1015_CHANNELS) { dev_err(&client->dev, "invalid channel index %d on %s\n", channel, node->full_name); |