summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSebastian Capella <sebastian.capella@linaro.org>2014-02-18 17:52:08 -0800
committerJiri Slaby <jslaby@suse.cz>2014-03-05 17:13:55 +0100
commit3787169fa3185aa8587972b5fdccbf700f60a4f1 (patch)
treef24803ec43b5cd42c95f092f47b02bc42cc24550
parent6e511735ceacf47932d0c123f786df7698a221b8 (diff)
PM / hibernate: Fix restore hang in freeze_processes()
commit f8d5b9e9e5372f0deb7bc1ab1088a9b60b0a793d upstream. During restore, pm_notifier chain are called with PM_RESTORE_PREPARE. The firmware_class driver handler fw_pm_notify does not have a handler for this. As a result, it keeps a reader on the kmod.c umhelper_sem. During freeze_processes, the call to __usermodehelper_disable tries to take a write lock on this semaphore and hangs waiting. Signed-off-by: Sebastian Capella <sebastian.capella@linaro.org> Acked-by: Ming Lei <ming.lei@canonical.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
-rw-r--r--drivers/base/firmware_class.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 10a4467c63f1..701212ba38b7 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -1529,6 +1529,7 @@ static int fw_pm_notify(struct notifier_block *notify_block,
switch (mode) {
case PM_HIBERNATION_PREPARE:
case PM_SUSPEND_PREPARE:
+ case PM_RESTORE_PREPARE:
kill_requests_without_uevent();
device_cache_fw_images();
break;