diff options
| author | Vasiliy Kulikov <segoon@openwall.com> | 2011-02-14 13:54:26 +0300 |
|---|---|---|
| committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2011-06-26 12:47:20 -0400 |
| commit | f8107dd119c9fd62aa0a3d3eb55d67bdd84b8036 (patch) | |
| tree | 5c94fe4ed7fe0e70fd2669e04288b1d85ba98ad7 | |
| parent | 973800f01aa1ab2bf5b8a412af07fc2cc568c783 (diff) | |
Bluetooth: sco: fix information leak to userspace
commit c4c896e1471aec3b004a693c689f60be3b17ac86 upstream.
struct sco_conninfo has one padding byte in the end. Local variable
cinfo of type sco_conninfo is copied to userspace with this uninizialized
one byte, leading to old stack contents leak.
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
| -rw-r--r-- | net/bluetooth/sco.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c index ca6b2ad1c3fc..5fa81fa92149 100644 --- a/net/bluetooth/sco.c +++ b/net/bluetooth/sco.c @@ -704,6 +704,7 @@ static int sco_sock_getsockopt_old(struct socket *sock, int optname, char __user break; } + memset(&cinfo, 0, sizeof(cinfo)); cinfo.hci_handle = sco_pi(sk)->conn->hcon->handle; memcpy(cinfo.dev_class, sco_pi(sk)->conn->hcon->dev_class, 3); |