diff options
| author | Robert Baldyga <r.baldyga@samsung.com> | 2014-11-24 07:56:21 +0100 |
|---|---|---|
| committer | Willy Tarreau <w@1wt.eu> | 2015-05-24 10:10:39 +0200 |
| commit | 17f35338d3b877b7434281e615e1926e560b97dc (patch) | |
| tree | e683029728152ae1fca2dcedfd1f9a93f0b71889 | |
| parent | d75221306dc828395739fee7efae402a5cc45df3 (diff) | |
serial: samsung: wait for transfer completion before clock disable
This patch adds waiting until transmit buffer and shifter will be empty
before clock disabling.
Without this fix it's possible to have clock disabled while data was
not transmited yet, which causes unproper state of TX line and problems
in following data transfers.
Cc: stable@vger.kernel.org
Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 1ff383a4c3eda8893ec61b02831826e1b1f46b41)
Signed-off-by: Willy Tarreau <w@1wt.eu>
| -rw-r--r-- | drivers/serial/samsung.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c index 1523e8d9ae77..fe6ef16b5956 100644 --- a/drivers/serial/samsung.c +++ b/drivers/serial/samsung.c @@ -443,11 +443,15 @@ static void s3c24xx_serial_pm(struct uart_port *port, unsigned int level, unsigned int old) { struct s3c24xx_uart_port *ourport = to_ourport(port); + int timeout = 10000; ourport->pm_level = level; switch (level) { case 3: + while (--timeout && !s3c24xx_serial_txempty_nofifo(port)) + udelay(100); + if (!IS_ERR(ourport->baudclk) && ourport->baudclk != NULL) clk_disable(ourport->baudclk); |