summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlasdair G Kergon <agk@redhat.com>2010-08-12 04:13:49 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2010-08-26 16:41:43 -0700
commit605a37bcc6f41f44d0093fec5f0816b5765f4e10 (patch)
tree7ff469285af57ac63640f98fc977dabae2a706f2
parent592de9cc7e8c4886d05139771e748da2e9f13f4b (diff)
dm mpath: fix NULL pointer dereference when path parameters missing
commit 6bbf79a14080a0c61212f53b4b87dc1a99fedf9c upstream. multipath_ctr() forgets to return an error after detecting missing path parameters. Fix this. Signed-off-by: Patrick LoPresti <lopresti@gmail.com> Signed-off-by: Alasdair G Kergon <agk@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/md/dm-mpath.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index 32d0b878eccc..f336c6959082 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -691,6 +691,7 @@ static struct priority_group *parse_priority_group(struct arg_set *as,
if (as->argc < nr_params) {
ti->error = "not enough path parameters";
+ r = -EINVAL;
goto bad;
}