summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNeil Brown <neilb@suse.de>2008-11-07 00:08:12 +0000
committerGreg Kroah-Hartman <gregkh@suse.de>2008-11-13 09:55:57 -0800
commit4ad8ad6f94ed1eb8abcb5a4001cef9da92bc84c2 (patch)
treeeb47c881f501eab121e1b16f6bd16dcf9c20b14a
parent83e387d13a81dab114b5f818f3c4abafcb9c7d2c (diff)
md: fix bug in raid10 recovery.
commit a53a6c85756339f82ff19e001e90cfba2d6299a8 upstream Adding a spare to a raid10 doesn't cause recovery to start. This is due to an silly type in commit 6c2fce2ef6b4821c21b5c42c7207cb9cf8c87eda and so is a bug in 2.6.27 and .28-rc. Thanks to Thomas Backlund for bisecting to find this. Cc: Thomas Backlund <tmb@mandriva.org> Cc: George Spelvin <linux@horizon.com> Signed-off-by: NeilBrown <neilb@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/md/raid10.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index e34cd0e62473..941576d4eceb 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -1132,7 +1132,7 @@ static int raid10_add_disk(mddev_t *mddev, mdk_rdev_t *rdev)
if (!enough(conf))
return -EINVAL;
- if (rdev->raid_disk)
+ if (rdev->raid_disk >= 0)
first = last = rdev->raid_disk;
if (rdev->saved_raid_disk >= 0 &&